Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Add new example showcasing how to attach two bodies #5250

Merged
merged 4 commits into from
Feb 26, 2025
Merged

[examples] Add new example showcasing how to attach two bodies #5250

merged 4 commits into from
Feb 26, 2025

Conversation

hugtalbot
Copy link
Contributor

Further to several requests, here is an example added to showcase how to attach two bodies, one soft and one rigid

BilateralLagrangianConstraint_Soft_Rigid_Bodies__r60_0001.mp4

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels Jan 29, 2025
@bakpaul
Copy link
Contributor

bakpaul commented Jan 30, 2025

Nice ! I would add springs on the bilaterals just for good practice

@hugtalbot
Copy link
Contributor Author

Let's keep it simple, shall we? 😇

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress and removed pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Feb 12, 2025
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Feb 12, 2025
@hugtalbot
Copy link
Contributor Author

up @bakpaul

@bakpaul
Copy link
Contributor

bakpaul commented Feb 12, 2025

The scene explodes at some point on my side...

@hugtalbot
Copy link
Contributor Author

up @bakpaul

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2025
@fredroy fredroy force-pushed the 202501_add_example_attachment_1 branch from 5224632 to dcfe9d5 Compare February 26, 2025 11:23
@fredroy
Copy link
Contributor

fredroy commented Feb 26, 2025

[ci-build][with-scene-tests]

@fredroy fredroy merged commit 093c67d into sofa-framework:master Feb 26, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: new feature Implement a new feature pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @bakpaul @fredroy